Support of ON DUPLICATE KEY for 'bulkCreate' method (only supported by mysql & mariadb) #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y mysql & mariadb)
| @@ -197,13 +198,21 @@ module.exports = (function() { | |||
| ')'); | |||
| }.bind(this)); | |||
|
|
|||
| if (options && options.updateOnDuplicate instanceof Array && options.updateOnDuplicate.length) { | |||
There was a problem hiding this comment.
I think this shouldn't update the createdAt timestamp.
I know you copied the code from usert, so the bug exists there as well ;) #2668
There was a problem hiding this comment.
Oh the fields are specified by an array. Disregard that comment then, I though you defaulted to all fields :)
There was a problem hiding this comment.
Would probably make sense to support true defaulting to all fields aswell.
There was a problem hiding this comment.
OK to support all fields by default.
…idate function fails on object literals"
|
Have you other comments? |
janmeier
added a commit
that referenced
this pull request
Dec 9, 2014
Support of ON DUPLICATE KEY for 'bulkCreate' method (only supported by mysql & mariadb)
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.