Add a Syslog octet counting frame decoder. (RFC6587) #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started with a FrameDecoder and am now working on the transport integration. |
bernd
force-pushed
the
syslog-tcp-octet-counting
branch
from
ac683e2
to
0f941b0
Compare
|
|
||
| @Override | ||
| public String linkToDocs() { | ||
| return ""; |
There was a problem hiding this comment.
This could link to http://www.graylog2.org/resources/documentation/sending/syslog but we'd need to add a section about syslog-ng and maybe a section on how to create a Syslog Input in Graylog2 to that document.
bernd
force-pushed
the
syslog-tcp-octet-counting
branch
from
0f941b0
to
b8a3a8f
Compare
| private boolean usesOctetCountFraming(MessageEvent e) { | ||
| final ChannelBuffer message = (ChannelBuffer) e.getMessage(); | ||
|
|
||
| return Character.isDigit(message.getByte(0)); |
There was a problem hiding this comment.
Could the ChannelBuffer ever be empty? If it can, this could throw an IndexOutOfBoundsException.
There was a problem hiding this comment.
While it's rather unlikely to happen here, Character#isDigit(char) matches much more than just [0-9]. Maybe rather use return '0' <= message.getByte(0) && message.getByte(0) <= '9'; instead.
|
LGTM! 👍 |
Also adjust to refactored transports.
bernd
force-pushed
the
syslog-tcp-octet-counting
branch
from
29c8d8f
to
21ee772
Compare
|
Merged via squash commit 6a77e02. |
bernd
referenced
this pull request
Oct 24, 2014
See: http://tools.ietf.org/html/rfc6587#section-3.4.1 Autodetect framing type to transparently support both methods on the same input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: http://tools.ietf.org/html/rfc6587#section-3.4.1