Extracted Piwik::getJavascriptCode() into a separate, non static class
#6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mnapoli! Clearing up |
…ass: `Piwik\Tracker\TrackerCodeGenerator` `Piwik::getJavascriptCode()` is now deprecated in favor of the new class.
mnapoli
force-pushed
the
refactoring-tracker-code-generator
branch
from
2deb4cc
to
d9562a6
Compare
…asn't an API method
|
As pointed by @tsteur it wasn't even an API method ( Waiting for the tests to pass before merge. |
mnapoli
added a commit
that referenced
this pull request
Oct 16, 2014
Extracted `Piwik::getJavascriptCode()` into a separate, non static class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted
Piwik::getJavascriptCode()into a separate, non static class:Piwik\Tracker\TrackerCodeGenerator.The content of the methods hasn't been modified, I have just moved them.
Why?
Piwikclass which has too many responsibilitiesPiwik::getJavascriptCode()is now deprecated in favor of the new class (I have changed the places where it was called). I added the deprecation to the changelog.I haven't renamed the
Piwik.getJavascriptCodeevent for backward compatibility.Feedback welcome.