Support for loading BitmapFonts from TextureAtlases #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added a field to the BitmapFontParameter -Improved documentation a bit
|
Makes sense to add support for this. Your current implementation has a couple of flaws. E.g. if an atlas is given, you still request textures as deps as well. Also not sure if ref counting works properly with this setup (e.g. does the font own the atlas and disposes of it?). |
| import com.badlogic.gdx.graphics.g2d.TextureRegion; | ||
| import com.badlogic.gdx.scenes.scene2d.ui.Skin; |
There was a problem hiding this comment.
That's probably for the Skin reference in the javadocs (for better or worse).
-Whoops, they shouldn't have been there in the first place
| regs[i] = new TextureRegion(manager.get(data.getImagePath(i), Texture.class)); | ||
| if (parameter.atlasName != null) { | ||
| // If we want to load this font from a texture atlas... | ||
| if (manager.getLoader(TextureAtlas.class) == null) { |
|
Fixed things up myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't actually tested this yet, I'm in the process of doing that, but I wanted to get some feedback first.
Anyway, isn't it weird that
BitmapFonts can be created fromTextureRegions, but you can't do so within aBitmapFontLoader? Being able to do so would be really, really convenient. Putting your fonts in the same atlas as your sprites would improve performance, and this PR makes it easier to do so.An update to the
BitmapFontTestis on the way.