Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query string is ignored in anchor href #261

Closed
AlexGalays opened this issue Sep 18, 2014 · 2 comments
Closed

Query string is ignored in anchor href #261

AlexGalays opened this issue Sep 18, 2014 · 2 comments
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@AlexGalays
Copy link 

m.route.mode = "hash";

m.route(document.body, "/page1", {
    "/page1": {
        controller: function() {}, 
        view: function() {
            return m("a", {href: '/page2?q=33', config: m.route}, "go to page 2")
        }
    },
    "/page2": {
        controller: function() {}, 
        view: function() {
            return m("a[href='/page1']", {config: m.route}, "go to page 1")
        }
    }
})

Whether the m("a", {href: '/page2?q=33'}) or m("a[href='/page2?q=33']") notation is used, the query string won't be included in the href property in the DOM.
@lhorie lhorie added the Type: Bug For bugs and any other unexpected breakage label Sep 20, 2014
@lhorie
Copy link
Member

lhorie commented Sep 20, 2014

Thanks for reporting. I'll look into it

@lhorie
Copy link
Member

lhorie commented Sep 20, 2014

This is fixed in origin/next and is scheduled to be released in v0.1.22

@lhorie lhorie closed this as completed Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexGalays @lhorie