Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: crazy limits, maximum length should be avoided #340

Closed
TheCapsLock opened this issue Jul 30, 2014 · 5 comments
Closed

Password: crazy limits, maximum length should be avoided #340

TheCapsLock opened this issue Jul 30, 2014 · 5 comments
Labels
💊 bug Something isn't working 🔨 enhancement Make it better, faster

Comments

@TheCapsLock
Copy link

Hi,
During some tests I found that using a password with a length of 80 fire an error with this message: "Password must contain at most 6 characters".

When using a password of 7 chars, it validates.

Putting a maximum limit on the size of a password is a bad security practise. This limit should disappear.
@unknwon
Copy link
Member

unknwon commented Jul 30, 2014

Password must contain at most 6 characters

Did you paste wrong error message?

And, we should remove the limitation, you're right!

@TheCapsLock
Copy link
Author

This was exactly this message.
Example (this password is 90 characters long):
{MWE5D`=kK]Qji$%A8}xMy^4bo]nVe6s<fm&vodQy/Uq N!fc3QH9s7;5@;j7S-MH{ -9c/,n@tEa4Gw?6h3k=N

Then the form looks like this after submitting it:
screenshot-code ffdn org 2014-07-30 20-55-35

@unknwon
Copy link
Member

unknwon commented Jul 30, 2014

Well, it pops wrong message which is another bug...

@unknwon unknwon added the Bug label Jul 30, 2014
@TheCapsLock
Copy link
Author

nice: 2 in one :)

unknwon added a commit that referenced this issue Aug 1, 2014
@unknwon
Fix #340
669552e
@unknwon unknwon closed this as completed Aug 1, 2014
@unknwon
Copy link
Member

unknwon commented Aug 1, 2014

Please test code on dev branch.

richmahn pushed a commit to richmahn/gogs that referenced this issue Dec 2, 2016
Fixes per Issue gogs#340
7e7b0fd
richmahn pushed a commit to richmahn/gogs that referenced this issue Dec 2, 2016
Fixes per Issue gogs#340
44a693e
phillip-hopper referenced this issue in unfoldingWord/dcs Dec 6, 2016
@richmahn
Feature - Scrub tool for each repo (#105)
b433a87 
* Scrubs sensantive information from JSON files

* Fixes per Issue #340

* Updates from code review

* Added scrub tool testing

* Fixes to testing

* Added committer and author

* Fixed options.tmpl

* Fixed bug
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working 🔨 enhancement Make it better, faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unknwon @TheCapsLock