Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone counts not updated correctly #303

Closed
nussjustin opened this issue Jul 23, 2014 · 1 comment
Closed

Milestone counts not updated correctly #303

nussjustin opened this issue Jul 23, 2014 · 1 comment
Labels
💊 bug Something isn't working

Comments

@nussjustin
Copy link
Contributor

When removing the only Issue from a milestone, the counter of the milestone doesn't get updated.

Looking at the log i get:

Adding an issue to the milestone:

[xorm] 2014/07/23 14:08:48.022621 [info] [sql] UPDATE `milestone` SET `repo_id` = ?, `index` = ?, `name` = ?, `num_issues` = ?, `deadline` = ? WHERE `id` = ? [args] [7 2 Milestone-2 1 9999-12-31 01:00:00 5]

Removing an issue from the milestone: (num_issues == 1)

[xorm] 2014/07/23 14:08:51.540087 [info] [sql] UPDATE `milestone` SET `repo_id` = ?, `index` = ?, `name` = ?, `deadline` = ? WHERE `id` = ? [args] [7 2 Milestone-2 9999-12-31 01:00:00 5]

I looked at the code and logged the values. Everything seems fine there. The struct gets updated, but the SQL is missing the num_issues value,
@unknwon unknwon added the Bug label Jul 23, 2014
@acusti acusti mentioned this issue Jul 24, 2014
Closed
@nussjustin nussjustin mentioned this issue Jul 24, 2014
Merged
unknwon added a commit that referenced this issue Jul 24, 2014
@unknwon
Merge pull request #310 from nuss-justin/issue/303
c4eeb80 
Fix #303. Specify updated columns explicitly.
@nussjustin
Copy link
Contributor Author

Closing this issue, was fixed by #310.

strk pushed a commit to strk/gogs that referenced this issue Nov 29, 2016
@tboerger
Merge pull request gogs#303 from tboerger/linting
4680c34 
Fixed remaining linting errors
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unknwon @nussjustin