Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding label fields if not repo owner/collaborator #288

Closed
nussjustin opened this issue Jul 16, 2014 · 1 comment
Closed

Hiding label fields if not repo owner/collaborator #288

nussjustin opened this issue Jul 16, 2014 · 1 comment
Labels
💊 bug Something isn't working 💻 ui You ruined my eyes!

Comments

@nussjustin
Copy link
Contributor

Hi,

I just noticed that the "Manage Labels" button and the "New Label" box are always visible, even if not loggedin.

As guest if i try to create a label, it asks me to login, and after login I get redirected to /USERNAME/REPOSITORY/issues/labels/new which just outputs a plain "Not found".

If I try to create a label on someones repo while loggedin the changes just get saved. This seems wrong for me, because with this behaviour anyone can create (and probably delete, but i didn't test this) labels.

I think it should only be possible to manage labels if the person logged in is a collaborator or the owner of a repo.
@unknwon unknwon added the UI label Jul 16, 2014
@unknwon
Copy link
Member

unknwon commented Jul 16, 2014

Thanks! I'll test it.

@unknwon unknwon added the Bug label Jul 16, 2014
@nussjustin nussjustin mentioned this issue Jul 22, 2014
Merged
unknwon added a commit that referenced this issue Jul 22, 2014
@unknwon
Merge pull request #297 from nuss-justin/issue/288
8e4debe 
Fix issue #288. Only show label form if repository collaborator/admin
@unknwon unknwon closed this as completed Jul 22, 2014
strk pushed a commit to strk/gogs that referenced this issue Nov 29, 2016
@tboerger
Merge pull request gogs#288 from tboerger/docker
16cdbe1 
Docker integration
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working 💻 ui You ruined my eyes!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unknwon @nussjustin