Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 should use XDomainRequest to avoid loading bar flashing #331

Merged
merged 1 commit into from Aug 17, 2014
Merged

IE8 should use XDomainRequest to avoid loading bar flashing #331

merged 1 commit into from Aug 17, 2014

Conversation

yujiosaka
Copy link

@rauchg
Copy link
Contributor

rauchg commented Aug 17, 2014

This PR is incredibly solid.

rauchg added a commit that referenced this pull request Aug 17, 2014
IE8 should use XDomainRequest to avoid loading bar flashing
@rauchg rauchg merged commit 0b9551f into socketio:master Aug 17, 2014
@rauchg
Copy link
Contributor

rauchg commented Aug 17, 2014

This PR should henceforth be referred to as the mother of all PRs.

@yujiosaka
Copy link
Author

@guille Thanks you!!

@3rd-Eden
Copy link
Contributor

You need to provide a way to turn this off as xdomainrequest is severely flawed. (Not sending cookies etc)

@yujiosaka
Copy link
Author

@3rd-Eden Thanks to your comment! I sent a PR to README (#332). Instead of adding a new option, I'd recommend you use forceJSONP.

@3rd-Eden
Copy link
Contributor

In #217 we removed this functionality for a reason. I personally would rather see a working connection with a loading bar then a dead connection.

@yujiosaka
Copy link
Author

@3rd-Eden I see your point. I fixed not to use XDR when crossing scheme in my PR. So the first flaw in #217 is not a problem. So the other one of not sending cookie is the main point then?

@yujiosaka
Copy link
Author

Should I create a new PR not to use XDR as default and provide an option to enable it?

@yujiosaka
Copy link
Author

OK, I closed #332 then.

@3rd-Eden
Copy link
Contributor

Using the forceJSON flag also prevents the use of regular XHR, I wouldn't really call this a solution.

@yujiosaka
Copy link
Author

OK, I did. #333

@skill7899
Copy link

....i have a probelm , it's about ie 6 7 8 loading bar flashing , my socket.io version 1.3.6 and when i run socket connect from a Static simple.html .the code :
var socket = io.connect('ws://xxxxxx:xxx');
socket.emit('login',{staffen:staffen,depId:depId});
socket.on('message',function(data){
})
})
it 'll be loading bar flashing in ie 6 7 8 ; can you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ie8 loading triggered by socket.io
4 participants