Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoConnect option #680

Merged
merged 2 commits into from Jun 22, 2014
Merged

Add autoConnect option #680

merged 2 commits into from Jun 22, 2014

Conversation

danielkcz
Copy link
Contributor

I am wondering why this has been removed in 1.0. I found it very handy in 0.9. I would like to just grab the instance of Manager, attach even listeners and then open the connection.

I know that in docs you are suggesting the following approach:

var manager = io.Manager('url', { /* options */ });
var socket = manager.socket('/namespace');
manager.on('event_name_like_reconnect_attempt', function() {
}); 

That seems rather silly, because this way it is skipping whole lookup mechanics and the manager is not cached. I would have to pass around manager instances in my application on my own. Having autoConnect option could be safer and easier way. Am I missing something here ?

rauchg added a commit that referenced this pull request Jun 22, 2014
@rauchg rauchg merged commit f8afcce into socketio:master Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants