fix decodePayloadAsBinary memory leak #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
added a commit
that referenced
this pull request
Jun 24, 2014
fix decodePayloadAsBinary memory leak
| @@ -1 +1,2 @@ | |||
| node_modules | |||
| .DS_Store | |||
|
Great fix. Thanks @christophwitzko! |
|
We should never face this problem unless the packet is flaud. Long term we should handle the case as an error, probably so that is propagates all the way to the socket so that the error can easily be handled and still doesn't break the connection. |
|
Well, since we don't have the idea of packet retransmission, I think |
|
Yup. Agreed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
datahas no byte with the value 255, theforloop will not exit andbufferTailgets bigger and bigger until the nodejs server (in my case) crashes.strLen.length > 310(Number.MAX_VALUE is about 310 characters long)