Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should use the standard http protocol to handler the etag header #1655

Merged
merged 1 commit into from Jul 1, 2014

Conversation

ysmood
Copy link
Contributor

@ysmood ysmood commented Jun 29, 2014

We should use the standard http protocol to handler the etag header. The client request header should be If-None-Match, not Etag.

@rauchg
Copy link
Contributor

rauchg commented Jul 1, 2014

File this one under "terrible test is terrible"

@rauchg
Copy link
Contributor

rauchg commented Jul 1, 2014

Thanks a lot for the fix

rauchg added a commit that referenced this pull request Jul 1, 2014
We should use the standard http protocol to handler the etag header
@rauchg rauchg merged commit 968e94e into socketio:master Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants