Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions for container size not being negative #5441

Closed
vaadin-bot opened this issue Jul 15, 2014 · 2 comments
Closed

Add assertions for container size not being negative #5441

vaadin-bot opened this issue Jul 15, 2014 · 2 comments
Labels
bug
Milestone
Vaadin 7.3.0.rc1

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @Legioth

It has turned out that e.g. can Table gets into a bad state if it's trying to use a Container that reports having a negative size. We might not want to make Table work with wonky containers, but we could at least add assertions to suitable places in the framework to give developers a chance of realizing what it is that causes the strange behavior.

Imported from https://dev.vaadin.com/ issue #14232
@vaadin-bot
Copy link
Collaborator Author

Originally by @Legioth

This one has a theoretical risk of causing regressions with some weird setups, so we might want to not include it in 7.2.x

@vaadin-bot
Copy link
Collaborator Author

Originally by @Legioth

As already noted in my previous comment, I don't think it's a good idea to include this commit in a maintenance release since it might actually break some theoretically broken applications that still happen to work by chance.

@vaadin-bot vaadin-bot added the bug label Dec 10, 2016
@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.rc1 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Vaadin 7.3.0.rc1
Development

No branches or pull requests
1 participant
@vaadin-bot