Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof site with html-proofer on change #2605

Merged
merged 4 commits into from Jul 16, 2014
Merged

Conversation

alfredxing
Copy link
Member

Adds a script to the CI build to proof the Jekyll site if it has been changed in the last commit or PR, as suggested in #2601.

First checks with git to see if the site/ directory has been changed. If it has, then continue, otherwise exit with code 0.

If html-proofer is not installed, install its nokogiri dependency with system libraries so it builds a lot faster. Then simply build the site with Jekyll and proof it.

@@ -1,4 +1,5 @@
#! /bin/bash

script/branding
script/proof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run this after all the tests! We could also scope the tests so they only run if a file was changed that would affect it.

parkr added a commit that referenced this pull request Jul 16, 2014
@parkr parkr merged commit 86cbffb into jekyll:master Jul 16, 2014
parkr added a commit that referenced this pull request Jul 16, 2014
@doktorbro
Copy link
Member

This is awesome.

Irony at https://travis-ci.org/jekyll/jekyll/jobs/30032882#L126:

Notice: for 10x faster LSI support, please install http://rb-gsl.rubyforge.org/

Rubyforge is dead.

@doktorbro doktorbro mentioned this pull request Jul 16, 2014
@alfredxing
Copy link
Member Author

@penibelst Speaking of RubyForge, we have quite a few links to it on our site that are broken. Any ideas what we should do with them?

@doktorbro
Copy link
Member

I would just remove the links and the related content. If people break the web, we don’t have to play bloodhounds.

@alfredxing
Copy link
Member Author

Sure. I'll fix it up after the latest Travis build finishes.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants