Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Jekyll::Tags::IncludeTag#blank? method #2625

Merged
merged 1 commit into from Jul 22, 2014
Merged

Remove unnecessary Jekyll::Tags::IncludeTag#blank? method #2625

merged 1 commit into from Jul 22, 2014

Conversation

fw42
Copy link
Contributor

@fw42 fw42 commented Jul 22, 2014

This was introduced in 421e58a to fix a break of backwards compatibility in Liquid 2.5 (Shopify/liquid#218). The commit that introduced that bug was reverted (the 2.5 and 2.6 branches don't contain any blank tag optimization), so this is not an issue anymore.

Also, the "bug" was fixed on master (upcoming Liquid 3.0) in Shopify/liquid@2efe809, so this shouldn't be necessary anymore.

@parkr, please take quick look.
cc @zerobase

@parkr
Copy link
Member

parkr commented Jul 22, 2014

LGTM! We'll just wait to make sure the travis build gives us 💚

@parkr parkr merged commit a776fda into jekyll:master Jul 22, 2014
@parkr
Copy link
Member

parkr commented Jul 22, 2014

GRÜN

parkr added a commit that referenced this pull request Jul 22, 2014
@parkr
Copy link
Member

parkr commented Jul 22, 2014

Thanks for the pull request, Flo!

@doktorbro
Copy link
Member

I’m really happy @fw42 helps here. Thank you very much.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants