Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about printer viewport weirdness #12345

Merged
merged 1 commit into from Jan 23, 2014
Merged

Conversation

cvrebert
Copy link
Collaborator

Addresses #12078.

@@ -528,6 +528,14 @@ <h3 id="support-fixed-position-keyboards">Modals, navbars, and virtual keyboards
<h3 id="support-browser-zooming">Browser zooming</h3>
<p>Page zooming inevitably presents rendering artifacts in some components, both in Bootstrap and the rest of the web. Depending on the issue, we may be able to fix it (search first and then open an issue if need be). However, we tend to ignore these as they often have no direct solution other than hacky workarounds.</p>

<h3 id="support-printing">Printer viewports</h3>
<p>Even in some modern browsers, printing can be quirky. In particular, as of Chrome v32 and regardless of margin settings, Chrome uses a viewport width significantly narrower that the physical paper size when resolving media queries when printing a webpage. This can result in Bootstrap's extra-small grid being unexpectedly activated when printing. <a href="https://github.com/twbs/bootstrap/issues/12078">See #12078 for some details.</a> Suggested workarounds:</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"narrower that the physical paper size" -> "narrower than the physical paper size"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest: "when resolving media queries when printing a webpage" -> "when resolving media queries while printing a webpage"

@juthilo
Copy link
Collaborator

juthilo commented Jan 23, 2014

Looks fine to me apart from the typo I just pointed out. :)

@cvrebert
Copy link
Collaborator Author

Thanks for the copyediting guys!
@mdo: Does this look good to you?

@cvrebert
Copy link
Collaborator Author

Also, I didn't notice before, but look at what this PR's issue number is!
🎆 1️⃣ 2️⃣ 3️⃣ 4️⃣ 5️⃣ 🎆

mdo added a commit that referenced this pull request Jan 23, 2014
add note about printer viewport weirdness
@mdo mdo merged commit 11a22fb into master Jan 23, 2014
@mdo mdo deleted the printer-wackiness-note branch January 23, 2014 01:52
@mdo
Copy link
Member

mdo commented Jan 23, 2014

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants