Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace .bs also to the event dismiss.modal #12270

Closed
wants to merge 1 commit into from
Closed

add namespace .bs also to the event dismiss.modal #12270

wants to merge 1 commit into from

Conversation

tlindig
Copy link
Contributor

@tlindig tlindig commented Jan 17, 2014

In modal.js, the dismiss events do not have the namespace .bs, but they should.

@cvrebert
Copy link
Collaborator

Sauce + BrowserStack tests pass: https://travis-ci.org/twbs/bootstrap/builds/17150656

@cvrebert
Copy link
Collaborator

Thanks!
Merged as 084f0fb. Had to rebase due to dist/js/bootstrap.min.js.

@cvrebert cvrebert closed this Jan 17, 2014
@mdo mdo mentioned this pull request Jan 17, 2014
Closed
@tlindig tlindig deleted the add_missing_namespace_to_dismiss branch January 26, 2014 21:38
@tlindig tlindig mentioned this pull request Feb 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlindig @cvrebert