Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear timeout on destroy. #11496

Merged
merged 1 commit into from Dec 27, 2013
Merged

Clear timeout on destroy. #11496

merged 1 commit into from Dec 27, 2013

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Nov 15, 2013

Clears the internal timeout on destroy so that hanging timers are not fired after destruction.

@fat does this need tests?

@satazor
Clear timeout on destroy.
926b940 
Clears the internal timeout on destroy so that hanging timers are not fired.
@cvrebert
Copy link
Collaborator

Duplicate of #10872, modulo using self vs. this.

@satazor
Copy link
Contributor Author

satazor commented Nov 16, 2013

Yea I think self is wrong there.

@fat
Copy link
Member

fat commented Dec 27, 2013

yep, thanks @satazor !

fat added a commit that referenced this pull request Dec 27, 2013
@fat
Merge pull request #11496 from satazor/patch-1
bf3c525 
Clear timeout on destroy.
@fat fat merged commit bf3c525 into twbs:master Dec 27, 2013
@fat
Copy link
Member

fat commented Dec 27, 2013

ah you snuck a semi in

@mdo mdo mentioned this pull request Dec 27, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@satazor @cvrebert @fat