Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'collapse' class back after expanding #10801

Merged
merged 1 commit into from Dec 27, 2013
Merged

Add 'collapse' class back after expanding #10801

merged 1 commit into from Dec 27, 2013

Conversation

HillTravis
Copy link
Contributor

The collapse class is replaced with the collapsing class while expanding, but it is never added back after the animation is complete. This functionality was changed for v3.0.0, but I think this detail was overlooked.

This breaks at least one third-party plugin: http://tarruda.github.io/bootstrap-datetimepicker/

@Ne-Ne
Copy link

Ne-Ne commented Oct 1, 2013

I have noticed that on load the collapse container closes.

I have created this CSS, it seems to hide any content both on load and when the panel is collapsed:

.panel-collapse collapse > * {
    visibility: hidden;
    display: none;
}

As I have a lot of content within the panel this seems to negate the massive surge of collapsing on load.

Could someone please test this.

-Neil

fat added a commit that referenced this pull request Dec 27, 2013
Add 'collapse' class back after expanding
@fat fat merged commit 37bfd8f into twbs:master Dec 27, 2013
@fat
Copy link
Member

fat commented Dec 27, 2013

sgtm thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants