don't create new Tooltip/Popover objects just to destroy them immediately #10761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fat
added a commit
that referenced
this pull request
Dec 27, 2013
…estroy don't create new Tooltip/Popover objects just to destroy them immediately
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
tooltip('destroy')is called on an element that does not have a tooltip, a Tooltip object is created only to be destroyed immediately afterward. I experience that behavior when creating the Tooltip on thebodywith a selector and destroying the potential targets in preparation of partial page update.The same is true for the Popover component.