Upgrade to Normalize v3 #12406
Merged
Upgrade to Normalize v3 #12406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cvrebert Gah, knew I forgot something. Just addressed both <3. |
|
LGTM, FWIW. |
|
What @cvrebert said :). |
|
Are you sure you don't want |
|
@XhmikosR We already set that in |
|
@mdo: I wasn't aware of that, thanks. |
|
@XhmikosR No worries, I wasn't either until I went and looked. This effectively cleans up a few lines of duplicate code, so yay! <3 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 will likely drop tomorrow. This updates our
normalize.lessto include all those changes, resets regular CSS comments to Less comments, and fixes a CSScomb issue.Would love some folks to check this out if they're got time.
/cc @cvrebert @juthilo