Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel-group last panel should margin-bottom #12171

Closed
mschipperheyn opened this issue Jan 9, 2014 · 2 comments
Closed

Panel-group last panel should margin-bottom #12171

mschipperheyn opened this issue Jan 9, 2014 · 2 comments
Labels
css
Milestone
v3.1.0

Comments

@mschipperheyn
Copy link

Panel-group reduces the margin between panels. However, the last panel in a panel-group should have a regular margin. Otherwise, other elements below the group will be affected by the reduced margin
@deviprsd
Copy link

deviprsd commented Jan 9, 2014

Should be ...
Small bug, I think it should be fixed.

@mdo
Copy link
Member

mdo commented Jan 9, 2014

Please provide a jsbin or jsfiddle demoing the bug.

@mdo mdo mentioned this issue Jan 11, 2014
Closed
@mdo mdo closed this as completed in 3a8e99e Jan 11, 2014
kevinawoo added a commit to Loopfirst/bootstrap that referenced this issue Mar 28, 2014
@kevinawoo
Merge remote-tracking branch 'remotes/upstream/master'
b2adb69 
* remotes/upstream/master: (76 commits)
  grunt dist
  Update docs per `.container-fluid` addition - Remove `.container-fluid` from "removed classes". - Container isn't fluid by default (`.container`) and `.row` isn't percentage-based, so update docs.
  Don't test Linux browsers since we don't support them officially and they're failing our tests
  Fixes twbs#12171: Ensure panel groups have a bottom margin since we nuke it on child panels
  refer to correct component
  docs mention for twbs#12188
  use height adjectives for greater clarity
  document twbs#11675
  rm outdated `<select>` references from comments in forms.less
  Clarify that the focus docs styles are not in the repo, per twbs/bootstrap-sass#497
  Fixes twbs#11990 and twbs#12159: Make range inputs block level and 100% wide by default
  grunt dist
  mixins.less: fix typo in comment
  use periods for consistency in each line
  Use absolute instead of relative URLs
  grunt dist
  Update paths in bower.json
  Add new varaible @icon-font-svg-id and set it to be the correct SVG font ID, used new variable in glyphicons.less
  missing a period after "Twitter, Inc"
  bump grunt-contrib-jade to v0.9.1
  ...

Conflicts:
	Gruntfile.js
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	less/variables.less
	test-infra/sauce_browsers.yml
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@mdo
(less) Fixes twbs#12171: Ensure panel groups have a bottom margin sin…
314f46a 
…ce we nuke it on child panels
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#12171: Ensure panel groups have a bottom margin sin…
bf01d5c 
…ce we nuke it on child panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
3 participants
@mdo @mschipperheyn @deviprsd