Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segmented buttons double border #11817

Merged
merged 1 commit into from Dec 15, 2013

Conversation

tlindig
Copy link
Contributor

@tlindig tlindig commented Dec 10, 2013

input-group-btn use nowrap. Inner btn get inline-block. In that combination, any space character between the button tags take its space. The old workaround try to fix it by using negative margin-left: -4px, but that does not work well, because it dose not depend on the font size. If you did not have a space between button tags and the left button was cropped.

I try a new solution. I set the font-size to 0, so space characters will have no size. And I set margin-left: -1px for siblings, to get 1px border.

Inner btn get set the own font-size, so it should have not negative side effects.

This will fix:
#11431
#9712

@mdo
Copy link
Member

mdo commented Dec 15, 2013

Already been resolved.

@tlindig
Copy link
Contributor Author

tlindig commented Dec 15, 2013

@mdo

Already been resolved.

#11435 is not a good solution. It conceals the problem, but does not address the cause.

@mdo mdo reopened this Dec 15, 2013
@mdo
Copy link
Member

mdo commented Dec 15, 2013

@tlindig Agreed, checking it out now.

@mdo mdo merged commit 3b5e0c9 into twbs:master Dec 15, 2013
@mdo mdo mentioned this pull request Dec 15, 2013
@mdo
Copy link
Member

mdo commented Dec 15, 2013

Revisited and merged!

@mdo mdo mentioned this pull request Dec 15, 2013
@zlatanvasovic
Copy link
Contributor

Good job. 😄

@tlindig tlindig deleted the fix_Segmented_buttons_double_border branch December 17, 2013 13:32
@tlindig tlindig mentioned this pull request Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants