Remove incompatible properties. #11744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to then add these |
|
It depends on what your intention is. I can look closer tomorrow if no one else beats me to it. |
|
@mdo: it seems to be OK as it is from a quick look I had. |
|
Looking into it, we do need to restore the |
Closed
|
@mdo BTW, I noticed these with csslint. There's a grunt plugin, do you think it's worth setting csslint up for BS? If so I could try making a PR. |
|
@XhmikosR Sure, let's give it a go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vertical-align: middleisn't compatible withdisplay: blockmargin-bottomisn't compatible withdisplay: inlineSo those properties didn't have any effect and can be removed.