Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of the visibility styles #11302

Merged
merged 1 commit into from Dec 15, 2013
Merged

Reduce size of the visibility styles #11302

merged 1 commit into from Dec 15, 2013

Conversation

zlatanvasovic
Copy link
Contributor

This reduces size of the visibility styles.

Fixes #11214 and half-fixes #8869 (don't target .hidden-* with display: block).

I tested this code on Bootstrap docs locally.

@zlatanvasovic
Copy link
Contributor Author

@mdo Should I add full fix for #8869, or just keep this pull request for minification of styles?

@mdo
Copy link
Member

mdo commented Nov 17, 2013

The problem as I understand it with this is that it doesn't make for mixin-friendly situations, right?

@zlatanvasovic
Copy link
Contributor Author

If you're talking about fix for #8869, my idea was something like:

.responsive-visibility() {
  display: block !important;
  tr& { display: table-row !important; }
  th&,
  td& { display: table-cell !important; }
  &.inline { display: inline-block !important; }
}

It's mixinable.

@mdo
Copy link
Member

mdo commented Dec 1, 2013

@zdroid I don't mean for that issue, I mean for this pull request. We need to maintain the mixin-friendly approach of the current implementation where anyone can use .visible-xs() and get all the appropriate styles.

@zlatanvasovic
Copy link
Contributor Author

@mdo Ok, I'll bring back the .responsive-invisibility() directly in classes. I'll do it tomorrow.

@zlatanvasovic
Copy link
Contributor Author

The same thing is for .*-print visibility utilities, I'm looking into them.

@zlatanvasovic
Copy link
Contributor Author

@mdo Mixinable now.

@mdo mdo merged commit 2b56ff0 into twbs:master Dec 15, 2013
@zlatanvasovic
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

responsive .hidden-* classes change from display block to inline-block
2 participants