Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbd styles #11193

Closed
zlatanvasovic opened this issue Oct 21, 2013 · 7 comments
Closed

kbd styles #11193

zlatanvasovic opened this issue Oct 21, 2013 · 7 comments
Milestone

Comments

@zlatanvasovic
Copy link
Contributor

It would be nice to have default kbd styles that really looks like keyboard button, but please not like buttons.

kbd is very useful element for documentation, and it's nice for keyboard shortcuts.

@mdo
Copy link
Member

mdo commented Oct 21, 2013

Are you thinking of using the element as the selector, or writing a new class to support this?

@zlatanvasovic
Copy link
Contributor Author

kbd selector is enought. Maybe additional class (like .kbd) would be nice, but it isn't really needed.

@zlatanvasovic
Copy link
Contributor Author

Hey. I found enought styles for this:

@kbd-bg: #f5f5f5;
@kbd-border: #ccc;
@kbd-border-bottom: #aaa;

kbd {
  padding: @padding-base-vertical @padding-base-horizontal;
  background-color: @kbd-bg;
  border: 1px solid @kbd-border;
  border-bottom: 1px solid @kbd-border-bottom;
  border-radius: @border-radius-base;
}

Variable values can be changed, but I think that this is enought styles (border, padding, border-radius, background). Thoughts?

@zlatanvasovic
Copy link
Contributor Author

@mdo Will the pull request help?

@mdo
Copy link
Member

mdo commented Oct 27, 2013

@zdroid Nah, I can do this when we're ready. We can't (shouldn't?) do it now though because technically it's a new feature, and new features shouldn't be part of a patch release. We'll have to do it for 3.1.

@zlatanvasovic
Copy link
Contributor Author

Right (I didn't thought about publishing it in 3.0.1).

2013/10/27 Mark Otto notifications@github.com

@zdroid https://github.com/ZDroid Nah, I can do this when we're ready.
We can't (shouldn't?) do it now though because technically it's a new
feature, and new features shouldn't be part of a patch release. We'll have
to do it for 3.1.


Reply to this email directly or view it on GitHubhttps://github.com//issues/11193#issuecomment-27164584
.

Zlatan Vasović - ZDroid

@mdo mdo mentioned this issue Dec 7, 2013
@mdo mdo closed this as completed in b1215d1 Dec 7, 2013
@zlatanvasovic
Copy link
Contributor Author

Thanks.

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants