Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome for Android 4.4 - node-scroll-info errors #1483

Closed
clarle opened this issue Dec 11, 2013 · 4 comments
Closed

Chrome for Android 4.4 - node-scroll-info errors #1483

clarle opened this issue Dec 11, 2013 · 4 comments
Labels
bug

Comments

@clarle
Copy link
Collaborator

clarle commented Dec 11, 2013 

ScrollInfo on Chrome (31.0.1650.59) / Linux
   in ScrollInfo
     body: getScrollInfo() should return current scroll information: 
     atBottom should be true after scrolling to bottom
       Expected: true (boolean)
       Actual: false (boolean)

     body: scrollToBottom event should fire after scrolling to the bottom: 
    Timeout: wait() called but resume() never called.

     body: scrollToRight event should fire after scrolling to the extreme right: 
    Timeout: wait() called but resume() never called.

Tested on a Nexus 7 (2012, 1st generation) with Android 4.4.2, errors are continuously reproducible.
@rgrove
Copy link
Contributor

rgrove commented Dec 12, 2013

Setting user-scalable=no in the test page's viewport meta tag resolves this, but that's obviously just squelching the problem since ScrollInfo needs to work on user-scalable pages as well.

Chrome for Android seems to choose a weird initial scale by default, and then doesn't report the correct pixel values when getting the height of the document. Which really sucks. :(

I'll have to investigate whether there's a way to work around this.

@ghost ghost assigned rgrove Dec 12, 2013
@clarle
Copy link
Collaborator Author

clarle commented Dec 12, 2013

@rgrove I'm guessing that this and #1484 have the same underlying issue then, with the weird scaling?

@rgrove
Copy link
Contributor

rgrove commented Dec 12, 2013

Seems likely, although I don't know anything about ScrollView.

rgrove added a commit that referenced this issue Dec 12, 2013
@rgrove
Fix node-scroll-info inaccuracy in Chrome for Android. Fixes #1483
c3bc43f
@triptych
Copy link
Contributor

Note for the future. If a bug's a release blocker let's note it in the description so everyone's aware.

@triptych triptych mentioned this issue Dec 12, 2013
Closed
@rgrove rgrove closed this as completed in 5a1d022 Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgrove @triptych @clarle