yui: Fix skin tests for latest Chrome/Android 4.4 #1501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Chrome and Android use the full value declaration for font properties such as `textDecoration`. They return: `underline solid rgb(0, 0, 0)` Instead of just: `underline`
|
If Chrome for android is returning Fixing the tests is reasonable, but if that's a supported environment (@msweeney), dom-style should be fixed, no? |
|
On the W3 spec for CSS3 http://www.w3.org/TR/css-text-decor-3/#text-decoration Technically Chrome/Android 4.4 are following spec in this case. The thing is whether we want to normalize this across browsers or not, but I think @msweeney mentioned we don't do that for things like fonts. |
|
Thanks! gtk. |
|
Merged in 332fed9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Chrome and Android return the full value declaration with
getComputedStylefor font properties such astextDecoration. They return:underline solid rgb(0, 0, 0)Instead of just:
underlineSince we don't normalize
getComputedStylefor shorthand like that, the tests just need to be fixed.\cc @msweeney