New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-out/in iframe code is not following HTML standard #4022
Comments
Of course last code should be:
Sorry, I was fighting with time to not be logged out again before clicking "Create ticket" |
Please can you propose pull request? http://piwik.org/participate/contributing-with-git/ |
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
fixes matomo-org#4022 [ci skip]
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
Original fix was only applied to `plugins/CoreAdminHome/templates/generalSettings.twig`.
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like this:
But should looks like this:
Because there are "pixels by default", values of those attributes should be just numbers. See http://www.w3.org/TR/html4/present/frames.html#h-16.5 or try to validate this code in validator.nu, you will get info that "p" after 200 and 600 is not a number.
That code could even look like:
Because it's good to use CSS for presentation, even in-line, and frameborder attribute is obsolete in HTML5.
Keywords: html, css, opt-out
The text was updated successfully, but these errors were encountered: