New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API CHANGE: Plugin Referers now called Referrers #4125
Labels
Critical
Indicates the severity of an issue is very critical and the issue has a very high priority.
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
worksforme
The issue cannot be reproduced and things work as intended.
Milestone
Comments
I've already renamed all translation keys accordingly. |
I vote for revert this change and instead:
|
In a27771e: Refs #4125 Renaming plugin from Referers to Referrers
|
This doesn't work. If you call "Referers" on API Version > 2.0.0 you get an error message. If you call the new word on old APIs you get an error message, too. I fixed it for myself with checking the API version, but maybe this helps another people. |
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…_ prefix are used if found.
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…ve out of OneVisitorTwoVisitsTest.
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…nd make sure code is backwards compatible.
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
* updating all variables/methods containing Referers * RENAMING custom segments definition, and custom scheduled reports definition, so that when they load "Referers" segment/report it still works as expected * RENAMING old archived data so that archived blobs are called Referrers * Reverting part of 0deb2bb * Update integration tests generating PDF+HTML with images on my dev box (GD 2.1 and PHP 5.5)
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…x (where `option` is a mysql reserved keyword)
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…rk by automatically loading the new plugin instead (kind of internal Redirects) refs matomo-org#4125 matomo-org#4219
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Critical
Indicates the severity of an issue is very critical and the issue has a very high priority.
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
worksforme
The issue cannot be reproduced and things work as intended.
Let's use the Piwik 2.0 release opportunity to rename some badly named plugins:
The text was updated successfully, but these errors were encountered: