Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all Phpstorm php warnings in Inspection tool #4123

Closed
mattab opened this issue Sep 6, 2013 · 6 comments
Closed

Fix all Phpstorm php warnings in Inspection tool #4123

mattab opened this issue Sep 6, 2013 · 6 comments
Assignees
@tsteur
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Sep 6, 2013

It is super useful to fix all Phpstorm php warnings in Inspection tool

eg since we do not have 100% code coverage, Phpstorm is amazingly helpful. Warnings == real bugs, eg. throw new Exception should be throw new \Exception
@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

In 588d71a: refs #4123 fix some phpstorm inspection warnings

@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

I think they are already fixed. Please reopen if not.

@mattab
Copy link
Member Author

mattab commented Oct 8, 2013

In f5fc4ee: refs #4123 Removing some warnings

@mattab
Copy link
Member Author

mattab commented Oct 8, 2013

In 186f09a: refs #4123 Removing unused imports (using phpstorm Inspections>Fix feature)

@mattab
Copy link
Member Author

mattab commented Oct 8, 2013

In d1d4472: Refs #4123 Applying phpstorm "Organize imports" on core/* and plugins/* directories

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4123 fix some phpstorm inspection warnings
588d71a
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
refs matomo-org#4123 Removing some warnings
f5fc4ee
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
refs matomo-org#4123 Removing unused imports (using phpstorm Inspecti…
186f09a 
…ons>Fix feature)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4123 Applying phpstorm "Organize imports" on core/* a…
d1d4472 
…nd plugins/* directories
@kalessil
Copy link

Not sure if it's good idea to comment closed tickets, but there is a plugin for PhpStorm - really advanced inspections.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @kalessil