Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compat code for PHP < 5.3 #4113

Closed
halfdan opened this issue Sep 3, 2013 · 10 comments
Closed

Remove compat code for PHP < 5.3 #4113

halfdan opened this issue Sep 3, 2013 · 10 comments
Assignees
@mattab
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@halfdan
Copy link
Member

halfdan commented Sep 3, 2013

We can clean the code base after raising the requirement to PHP 5.3.

There are some compat functions in core/IP.php because Windows with PHP < 5.3 did not provide inet_ntop/inet_pton.
@anonymous-matomo-user
Copy link

In 3f7a679: Remove compat code for PHP < 5.3. inet_pton/inet_ntop are available in Windows in PHP >= 5.3 so we don't need the compat code anymore.

refs #3741, #4113

@anonymous-matomo-user
Copy link

In d507de9: Remove more pre 5.3 compat code

refs #4113

@anonymous-matomo-user
Copy link

In d2e842fbc3c70a7e2264ad978d1e36798f24a8a6: Remove upgradephp library

refs #4113

@halfdan
Copy link
Member Author

halfdan commented Sep 4, 2013

Reverted the last commit. upgradephp should be merged with core somehow. We don't need to upgrade some of the functions anymore.

Any reason for #1900? What's the point of not unserializing objects - as long as we don't execute anything we should be safe, right?

@anonymous-matomo-user
Copy link

In f229dbc: Replace create_function calls with lambda functions.
This allows the IDE to pick up all code!

refs #4113

@robocoder
Copy link
Contributor

@halfdan #1900 was for http://www.suspekt.org/2009/12/09/advisory-032009-piwik-cookie-unserialize-vulnerability/

@halfdan
Copy link
Member Author

halfdan commented Sep 5, 2013

@vipsoft: Thanks for the info!

@mattab
Copy link
Member

mattab commented Sep 6, 2013

Good to get it done for 2.0.

What is left on this ticket?

@halfdan
Copy link
Member Author

halfdan commented Sep 6, 2013

We need to check what we need from libs/upgradephp - there are some patches that Anthon mentioned above, but also some code that could be removed. So maybe we could merge the remainders into core.

There are also some functions in core (e.g. IP::N2P etc.) that could be removed.

@mattab
Copy link
Member

mattab commented Sep 6, 2013

Could you simply list all functions you think should be deleted, in the ticket description, and I'll investigate for sure.

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Remove compat code for PHP < 5.3. inet_pton/inet_ntop are available i…
3f7a679 
…n Windows in PHP >= 5.3 so we don't need the compat code anymore.

refs matomo-org#3741, matomo-org#4113
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Remove more pre 5.3 compat code
d507de9 
refs matomo-org#4113
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Replace create_function calls with lambda functions.
f229dbc 
This allows the IDE to pick up all code!

refs matomo-org#4113
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@halfdan @mattab @robocoder @anonymous-matomo-user