Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethinkdb admin "help" command wants to run in a pager, with no terminal width, in eshell. #936

Closed
srh opened this issue May 31, 2013 · 6 comments
Assignees
Milestone

Comments

@srh
Copy link
Contributor

srh commented May 31, 2013

Open emacs. Run M-x shell. Run rethinkdb admin. Run the help command. You get this:

WARNING: terminal is not fully functional
-  (press RETURN) 
INFO

      rethinkdb
      admin
      console
      -
      access
      or
      modify
      cluster
      metadata,
      run
      'help
@ghost ghost assigned Tryneus May 31, 2013
@srh
Copy link
Contributor Author

srh commented Sep 20, 2013

I just came here to report this issue and found that I had already reported it.

rethinkdb admin also prints out bolding and unbolding escapes that don't work so nicely when paging it through cat or less. None of the other commands see fit to do this.

@mlucy
Copy link
Member

mlucy commented Sep 20, 2013

I thought @Tryneus fixed this just recently(ish)?

@Tryneus
Copy link
Member

Tryneus commented Sep 20, 2013

I removed the help pager entirely, so that really shouldn't be a problem anymore. However, the control characters are certainly still there, I did nothing to change that. As far as I remember, control characters for bold and underline are used, but only on help commands. I don't know if there's an easy way to detect the terminal capabilities to filter those out, or we could just remove them entirely (though I think that would hurt the general use case).

@mlucy
Copy link
Member

mlucy commented Sep 20, 2013

We almost certainly shouldn't be sending control characters to things that we don't know can use them. We should detect whether we're talking to a tty, and if we are, we should use getenv or the like to make sure we aren't talking to a dumb terminal. (I'm not sure this is worth doing immediately.)

@Tryneus
Copy link
Member

Tryneus commented Sep 20, 2013

Ok, I implemented a fix for the terminal command codes in review 950.

@Tryneus
Copy link
Member

Tryneus commented Sep 24, 2013

This has been approved and merged into next in commit cf9d300. Will be in release 1.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants