make python driver install backup scripts #1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than cycle through multiple potential python binaries with which to run a script hoping to find the appropriate package, it makes much more sense to install the scripts with their dependency into the location of the python binary with which the package was installed. this pegs the #! to the version of python used to install (whether system version or venv) and allows the script to run in the appropriate environment.
|
Thanks, this is a great idea. It also fixes one of the issues mentioned in #1349 Before we can merge this, I have to make two additional changes:
|
ghost
assigned 
|
Cool. I did do a git mv on the files from the scripts/backup (unless they are also somewhere else?), but i did not touch the Makefile. And you're right - the scripts themselves handled error messages when the package was missing and that would need to be handled. Thanks for your help making this work. |
|
@underrun -- could you sign http://rethinkdb.com/community/cla/ if you haven't already? |
|
done |
|
Thanks @underrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than cycle through multiple potential python binaries with which
to run a script hoping to find the appropriate package, it makes much
more sense to install the scripts with their dependency into the
location of the python binary with which the package was installed.
this pegs the #! to the version of python used to install (whether
system version or venv) and allows the script to run in the appropriate
environment.