Issue 15303003: UI Updates for OSX App Launcher: truncate titles, window shadow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15303003: UI Updates for OSX App Launcher: truncate titles, window shadow. (Closed)

Created:
7 years, 7 months ago by tapted

Modified:
7 years, 7 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, sail+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

UI Updates for OSX App Launcher: truncate titles, window shadow. Truncate titles on button labels, replacing the end of long titles with with the ellipsis glyph. Also, restore the default OS window shadow for now. BUG=138633 TEST=Show some apps with long titles in the app launcher, they should end with an ellipsis rather than getting cut off. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201049

Patch Set 1 #

Patch Set 2 : need to set #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/app_list/cocoa/app_list_window_controller.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/app_list/cocoa/apps_grid_view_item.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/15303003/2002

7 years, 7 months ago (2013-05-20 01:34:07 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150843

7 years, 7 months ago (2013-05-20 04:24:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/15303003/2002

7 years, 7 months ago (2013-05-20 04:38:36 UTC) #5

Message was sent while issue was closed.

Change committed as 201049

Expand Messages | Collapse Messages