Opened 11 years ago
Closed 11 years ago
#9765 closed Bug (fixed)
Toolbar Collapse command documented incorrectly on Accessibility Instructions dialog
| Reported by: | Satya Minnekanti | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0.1 |
| Component: | Accessibility | Version: | 4.0 Beta |
| Keywords: | IBM | Cc: | Damian, Teresa Monahan |
Description
To reproduce the defect:
- Open any CK Editor sample, navigate to editor body and press ALT + ZERO.
- Accessibility Instructions dialog comes up.
- See the Command shown for Toolbar Collapse Command
Issue: it says Press Ctrl + Z which is incorrect it should say Alt + SUBTRACT
This is only happening in 4.0 & not in 3.6.x stream & it's a regression
Attachments (1)
Change History (13)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | 4.0 → 4.0 Beta |
comment:2 Changed 11 years ago by
| Milestone: | → CKEditor 4.0.1 |
|---|
comment:4 Changed 11 years ago by
| Component: | General → Accessibility |
|---|
comment:5 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
Changed 11 years ago by
comment:7 Changed 11 years ago by
| Status: | assigned → review |
|---|
Pushed a commit to t/9765, which solves an issue. This fix basically omits all the a11y help entries that contain a reference to the keystroke undefined in editor.keystrokeHandler.keystrokes.
comment:8 Changed 11 years ago by
| Owner: | changed from Olek Nowodziński to Piotrek Koszuliński |
|---|
- swapKeystrokes is called multiple times on one dialog open. I pushed commit fixing this.
- ALT+- keystroke doesn't work for me on FF (Linux and Win). There's
CKEDITOR.ALT + ( CKEDITOR.env.ie || CKEDITOR.env.webkit ? 189 : 109 )when on FF "-" is 173. Extracted this issue to #9827.
comment:9 follow-up: 10 Changed 11 years ago by
PS. regarding 1. - if you tried to make this dialog aware of changes in keystrokes, then it couldn't work, because dialog's content is generated once, on first dialog opening.
comment:10 Changed 11 years ago by
Replying to Reinmar:
PS. regarding 1. - if you tried to make this dialog aware of changes in keystrokes, then it couldn't work, because dialog's content is generated once, on first dialog opening.
Nope, I didn't. I'm aware of this fact.
comment:11 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:12 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Masterised git:4c8f77e.
If
config.toolbarCanCollapse=true;is defined then dialog shows Alt+SUBTRUCT whne it is set to false dialog shows Ctrl+Z.