#8654 closed bug (fixed)

Opened October 11, 2012 08:51AM UTC

Closed October 14, 2012 08:52PM UTC

Last modified October 25, 2012 02:25PM UTC

Spinner input has no background

Reported by: nicola7290 Owned by: nicola7290
Priority: minor Milestone: 1.9.1
Component: ui.spinner Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:
Description

When I create a Spinner Widget the background-color of the spinner is trasparent and this can create problem with the background-color of the page.

I think it's a mistake.

span.ui-spinner {
    background: none repeat scroll 0 0 transparent;
}
Attachments (0)
Change History (6)

Changed October 11, 2012 12:54PM UTC by scottgonzalez comment:1

component: CSS Framework → ui.spinner
owner: → nicola7290
status: new → pending

The rule is actually span.ui-spinner { background: none; } Regardless, I don't see how this would cause a problem, can you provide an example of where this is problematic?

Changed October 11, 2012 03:48PM UTC by nicola7290 comment:2

status: pending → new

Can you go at this link, please?

http://suite.sogiscuola.com/_librerie/_jquery-ui-1.9.0/index.html

Go at the bottom of the page, where I add the section "Spinner".

I think that the spinner should have a default background-color (#ffffff ?) as normal input text.

Bye

Changed October 11, 2012 04:22PM UTC by scottgonzalez comment:3

status: new → open

Yeah, that makes sense. I assume this was done because no other form controls are styled right now. I'll have to track down who added that rule and find out why it was done.

Changed October 12, 2012 01:48AM UTC by scottgonzalez comment:4

Well, this has been there since "the beginning": https://github.com/jquery/jquery-ui/commit/f7d8a1ba570fd620d65b377ebe806eac0b578328#diff-8

I'll talk to the rest of the team and see if anyone knows for sure why this was done.

Changed October 14, 2012 08:52PM UTC by Jörn Zaefferer comment:5

resolution: → fixed
status: open → closed

Spinner: Remove ui-state- classes from spinner, along with the background:none TR override. Fixes #8654 - Spinner background-color

Changeset: 112185ec8ddb7f0849fa40e7b1409e28153555f8

Changed October 25, 2012 02:25PM UTC by jzaefferer comment:6

summary: Spinner background-color → Spinner input has no background