Widget: Destroy only when element is the actual target. Fixes #8652 -…

… Widget: Destroy only when element is the actual target.
jquery · Oct 23, 2012 · 8bb05d2 · 8bb05d2 · jzaefferer · Nov 26, 2012
1 parent b1b07e8
commit 8bb05d2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/tests/unit/widget/widget_core.js b/tests/unit/widget/widget_core.js
@@ -1167,6 +1167,13 @@ test( "._trigger() - instance as element", function() {
 			$( "#widget" ).testWidget().detach();
 		});
 	});
+
+	test( "destroy - remove event bubbling", function() {
+		shouldDestroy( false, function() {
+			$( "<div>child</div>" ).appendTo( $( "#widget" ).testWidget() )
+				.trigger( "remove" );
+		});
+	});
 }());
 
 test( "redefine", function() {

diff --git a/ui/jquery.ui.widget.js b/ui/jquery.ui.widget.js
@@ -237,7 +237,13 @@ $.Widget.prototype = {
 			// TODO remove dual storage
 			$.data( element, this.widgetName, this );
 			$.data( element, this.widgetFullName, this );
-			this._on({ remove: "destroy" });
+			this._on({
+				remove: function( event ) {
+					if ( event.target === element ) {
+						this.destroy();
+					}
+				}
+			});
 			this.document = $( element.style ?
 				// element within the document
 				element.ownerDocument :