Core: Update :focsable and :tabbable to handle parents with no height…

…/width, but visible overflow. Fixes #8643 - :focusable pseudo-selector does not find elements if parent has 0x0 dimension.
jquery · Oct 23, 2012 · 86a958d · 86a958d
1 parent 97b4813
commit 86a958d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/tests/unit/core/core.html b/tests/unit/core/core.html
@@ -112,6 +112,11 @@ <h2 id="qunit-userAgent"></h2>
 	<span id="spanTabindex-50" tabindex="-50">.</span>
 </div>
 
+<div style="width: 0; height: 0;">
+	<input id="dimensionlessParent">
+	<input id="dimensionlessParent-dimensionless" style="height: 0; width: 0;">
+</div>
+
 <div id="zIndex100" style="z-index: 100; position: absolute">
 	<div id="zIndexAutoWithParent">.</div>
 </div>

diff --git a/tests/unit/core/selector.js b/tests/unit/core/selector.js
@@ -157,6 +157,12 @@ test("focusable - area elements", function() {
 	isNotFocusable('#areaNoImg', 'not associated with an image');
 });
 
+test( "focusable - dimensionless parent with overflow", function() {
+	expect( 1 );
+
+	isFocusable( "#dimensionlessParent", "input" );
+});
+
 test("tabbable - visible, enabled elements", function() {
 	expect(18);
 
@@ -236,4 +242,10 @@ test("tabbable - area elements", function() {
 	isNotTabbable('#areaNoImg', 'not associated with an image');
 });
 
+test( "tabbable - dimensionless parent with overflow", function() {
+	expect( 1 );
+
+	isTabbable( "#dimensionlessParent", "input" );
+});
+
 })(jQuery);
diff --git a/ui/jquery.ui.core.js b/ui/jquery.ui.core.js
@@ -198,10 +198,10 @@ function focusable( element, isTabIndexNotNaN ) {
 }
 
 function visible( element ) {
-	return !$( element ).parents().andSelf().filter(function() {
-		return $.css( this, "visibility" ) === "hidden" ||
-			$.expr.filters.hidden( this );
-	}).length;
+	return $.expr.filters.visible( element ) &&
+		!$( element ).parents().andSelf().filter(function() {
+			return $.css( this, "visibility" ) === "hidden";
+		}).length;
 }
 
 $.extend( $.expr[ ":" ], {