Combine server and static build configs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradDenver
added a commit
that referenced
this pull request
Jan 19, 2015
Combine server and static build configs
|
Thanks very much for this pull request @lettertwo. So the thing I had missed was that I had left my entry points as a flat array when they needed to be an object as the object keys set the |
|
👍 perhaps it's not so obvious, when so many different values are valid (an array, a string, or an object of keys mapping to arrays or strings)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in your blog post on this project:
snip
If I understand what you want correctly, then this PR accomplishes just what you want!
Nice work!