Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capturePage returning empty buffer #847

Closed
twolfson opened this issue Nov 21, 2014 · 5 comments
Closed

capturePage returning empty buffer #847

twolfson opened this issue Nov 21, 2014 · 5 comments

Comments

@twolfson
Copy link
Contributor

This seems to have occurred in #223 but I decided that we should create a new issue since the cause might have changed.

I am trying to use atom-shell as a screenshott utility since it is a more accurate renderer than phantomjs. In atom-shell@v0.19.3, it looks like capturePage is returning an empty buffer whereas older versions return a full buffer. I have created a gist to reproduce the issue:

https://gist.github.com/twolfson/0d374d9d7f26eefe7d38

0.19.3:

$ atom-shell main.js 
[29590:1120/231008:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[29618:1120/231009:INFO:renderer_main.cc(204)] Renderer process started
<Buffer >
[29590:1120/231012:ERROR:channel.cc(316)] RawChannel read error (connection broken)
[29590:1120/231012:ERROR:atom_main_delegate.cc(93)] ProcessExiting:

0.13.3:

$ ~/Downloads/atom/atom-shell-v0.13.3-linux-x64/atom main.js 
[30028:1120/231335:INFO:renderer_main.cc(227)] Renderer process started
<Buffer 89 50 4e 47 0d 0a 1a 0a 00 00 00 0d 49 48 44 52 00 00 03 1e 00 00 02 37 08 02 00 00 00 9a 8c 1a 23 00 00 20 00 49 44 41 54 78 9c ec dd 79 98 5d 55 95 ... >
@twolfson
Copy link
Contributor Author

I have traced it down to breaking between 0.17.2 and 0.18.0:

0.18.0:

$ ~/Downloads/atom/atom-shell-v0.18.0-linux-x64/atom main.js 
[31163:1120/232455:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[31193:1120/232455:INFO:renderer_main.cc(204)] Renderer process started
<Buffer >

0.17.2:

$ ~/Downloads/atom/atom-shell-v0.17.2-linux-x64/atom main.js 
[30933:1120/232312:ERROR:browser_main_loop.cc(161)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[30961:1120/232312:INFO:renderer_main.cc(227)] Renderer process started
<Buffer 89 50 4e 47 0d 0a 1a 0a 00 00 00 0d 49 48 44 52 00 00 03 20 00 00 02 58 08 02 00 00 00 15 14 15 27 00 00 20 00 49 44 41 54 78 9c ec dd 77 98 9d 55 b5 ... >
[30933:1120/232315:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer

@twolfson
Copy link
Contributor Author

For reference, I am using the linux-x64 releases on Linux Mint 14.

@cpsubrian
Copy link

👍 Confirmed same issue with Darwin build between the exact same versions.

@zcbenz zcbenz added the bug label Nov 24, 2014
@zcbenz zcbenz closed this as completed in a9b1b56 Nov 24, 2014
@twolfson
Copy link
Contributor Author

❤️

@cpsubrian
Copy link

❤️ ❤️ 🍰 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpsubrian @zcbenz @twolfson