Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the notary version to one that fixes a bug with delegation path traversal #20523

Merged
merged 1 commit into from Feb 20, 2016
Merged

Bump the notary version to one that fixes a bug with delegation path traversal #20523

merged 1 commit into from Feb 20, 2016

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Feb 19, 2016

No description provided.

@@ -249,3 +249,5 @@ ENTRYPOINT ["hack/dind"]

# Upload docker source
COPY . /go/src/github.com/docker/docker

RUN set -x && GOPATH=$(pwd)/vendor/src/github.com/docker/notary/Godeps/_workspace:$GOPATH go build -o /usr/local/bin/notary-server github.com/docker/notary/cmd/notary-server &&GOPATH=$(pwd)/vendor/src/github.com/docker/notary/Godeps/_workspace:$GOPATH go build -o /usr/local/bin/notary github.com/docker/notary/cmd/notary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clarify why that's needed? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, that was a bug in my autovendoring notary script. :) Fixing

…traversal

Signed-off-by: cyli <cyli@twistedmatrix.com>
@GordonTheTurtle
Copy link

Job: Docker-PRs-WoW-TP4 FAILED:

---
19T23:10:48Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0" 
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End of cleanup
INFO: Ended at Fri Feb 19 23:10:48 CUT 2016 (0m 3s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\jenkins\hudson3506047074075676062.sh
+ set +e
+ set +x
INFO: Nuking /d/CI
time="2016-02-19T23:10:51Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0" 
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End
---

@tiborvass
Copy link
Contributor

LGTM

1 similar comment
@icecrime
Copy link
Contributor

LGTM

tiborvass added a commit that referenced this pull request Feb 20, 2016
…1.10.2

Bump the notary version to one that fixes a bug with delegation path traversal
@tiborvass tiborvass merged commit 1bfaf31 into moby:bump_v1.10.2 Feb 20, 2016
@cyli cyli deleted the vendor-notary-version-for-docker-1.10.2 branch February 20, 2016 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants