Close tarsplit gzip writer when creating tar-split.json.gz files during layer migration #20458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng layer migration There is a missing call to Close on the gzip.Writer that is used to compress newly created tar-split files during layer migration. This can result in corrupt tar-split files that later cause docker push and docker save to fail. The Close call is necessary to flush buffered data to the stream. Fixes: moby#20104 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
icecrime
pushed a commit
that referenced
this pull request
Feb 19, 2016
Close tarsplit gzip writer when creating tar-split.json.gz files during layer migration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing call to Close on the gzip.Writer that is used to
compress newly created tar-split files during layer migration. This can
result in corrupt tar-split files that later cause docker push and
docker save to fail. The Close call is necessary to flush buffered data
to the stream.
Fixes #20104
cc @tonistiigi @dmcgowan