New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon: fix reuse of osd ids (clear osd info on osd deletion) #6900
Conversation
When an OSD id is removed via ceph osd rm, it will be reused by the next ceph osd create command. Verify that and OSD reusing such an id successfully comes up. http://tracker.ceph.com/issues/13988 Refs: ceph#13988 Signed-off-by: Loic Dachary <loic@dachary.org>
pg_temp is not osd-based, and the mon cleans it up. yes on primary affinity. same for state. repushing! |
If we destroy an OSD in the map, clear not just the uuid but also all the metadata about it. Specifically, we care about up_from, which can prevent a new OSD from booting if it starts with a map prior to the deletion when it sends it boot. Specifically, the osd epoch may be 0 and if the latest osd epoch is also small the osd decide it is "close enough" to the latest epoch and sends the boot message. In practice this problem wouldn't surface on any cluster that isn't brand new. Note that this changes the result of applying an incremental. As such, it will cause lots of old OSDs to request full maps from the mon, spiking load during an upgrade. This is as it should be. Fixes: ceph#13988 Signed-off-by: Sage Weil <sage@redhat.com>
5ae5e0d
to
4e28f9e
Compare
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
Running the ceph-disk suite which hits the bug every time on master teuthology-openstack --verbose --key-filename ~/Downloads/myself --key-name myself --teuthology-git-url http://github.com/dachary/teuthology --teuthology-branch wip-suite --ceph-qa-suite-git-url http://github.com/ceph/ceph-qa-suite --suite-branch master --ceph-git-url http://github.com/liewegas/ceph --ceph wip-13988 --suite ceph-disk --filter ubuntu_14.04 |
@liewegas could you update the commit message regarding the upgrade ? Since it has no influence on anything user visible, I assume the merge commit can be empty and not be highlighted in the release notes. |
@liewegas the bot failure is from http://tracker.ceph.com/issues/13986 and should be ignored. |
mon: fix reuse of osd ids (clear osd info on osd deletion) Reviewed-by: Loic Dachary <ldachary@redhat.com>
http://tracker.ceph.com/issues/13988