common/address_help.cc: fix the leak in entity_addr_from_url() #6987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but keep commit message title within 80 chars will be better |
|
@qiankunzheng could you update the commit message to add an before the tracker ticket number, like: ? would be better. |
qiankunzheng
changed the title
|
@tchaikov |
|
lgtm, would be ideal if jenkins can also nod on this. i grep'ed the repo, |
Fixes: #14132 Signed-off-by: Qiankun Zheng <zheng.qiankun@h3c.com>
|
@tchaikov |
|
@qiankunzheng sorry for the latency, the jenkins is disabled at this moment, merging it! |
tchaikov
added a commit
that referenced
this pull request
Dec 28, 2015
common/address_help.cc: fix the leak in entity_addr_from_url() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:#14132
Signed-off-by: Qiankun Zheng zheng.qiankun@h3c.com