[ngAria] aria-required is not allowed for input type="checkbox" #13078

k7sleeper · 2015-10-13T09:05:50Z

We've the problem that ngAria adds attribute aria-required to our checkboxes and W3C Validator rightly complains about that.

What am I doing wrong? Or is it an issue in ngAria?

gkalpak · 2015-10-13T11:44:23Z

Could you provide a demo of the issue (preferrably a live reproduction using CodePen, Plnkr etc) ?

Narretz · 2015-10-15T21:58:18Z

I think this is going to be fixed by #13095

gkalpak · 2015-10-16T14:00:49Z

@Narretz, I thought #13095 is about tabindex (this one is about aria-required). No ?

marcysutton · 2015-10-22T19:46:05Z

We need another PR to cover extraneous aria-* attributes....it piggybacks on the tabindex work, but should remain separate. I'll get on it! :)

Narretz · 2015-10-27T16:27:25Z

Yeah, it's a different issue, sorry for the noise. Thanks @marcysutton for all the work!

BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. New support added for ngValue, ngChecked, and ngRequired, along with updated documentation. Closes angular#13078 Closes angular#11374 Closes angular#11830

Narretz added the component: ngAria label Oct 15, 2015

Narretz added this to the Purgatory milestone Oct 15, 2015

Narretz added the needs: more info label Oct 15, 2015

Narretz modified the milestones: 1.4.x, Purgatory Oct 27, 2015

Narretz added type: bug and removed needs: more info labels Oct 27, 2015

marcysutton mentioned this issue Dec 9, 2015

fix(ngAria): Apply ARIA attrs correctly #13483

Closed

gkalpak closed this as completed in d06431e Feb 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ngAria] aria-required is not allowed for input type="checkbox" #13078

[ngAria] aria-required is not allowed for input type="checkbox" #13078

k7sleeper commented Oct 13, 2015

gkalpak commented Oct 13, 2015 •

edited

Narretz commented Oct 15, 2015

gkalpak commented Oct 16, 2015

marcysutton commented Oct 22, 2015

Narretz commented Oct 27, 2015

[ngAria] aria-required is not allowed for input type="checkbox" #13078

[ngAria] aria-required is not allowed for input type="checkbox" #13078

Comments

k7sleeper commented Oct 13, 2015

gkalpak commented Oct 13, 2015 • edited

Narretz commented Oct 15, 2015

gkalpak commented Oct 16, 2015

marcysutton commented Oct 22, 2015

Narretz commented Oct 27, 2015

gkalpak commented Oct 13, 2015 •

edited