Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side-by-side diff view #1925

Closed
andreynering opened this issue Nov 11, 2015 · 19 comments
Closed

Side-by-side diff view #1925

andreynering opened this issue Nov 11, 2015 · 19 comments
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Milestone
0.9.0

Comments

@andreynering
Copy link
Contributor

I don't know how hard it would be to implement it. Feel free to close this issue if you don't intent to bring this to Gogs.

Side-by-side diff is supported by GitHub and GitLab, and I think it is much easier to see a what changed in a commit. Don't know what tool they use, though.

sidebyside3

sidebyside2
@unknwon unknwon added the 🎯 feature Categorizes as related to a new feature label Nov 11, 2015
@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

Thanks your feedback!

But may take long long time... I am not sure.. 😅

@andreynering
Copy link
Contributor Author

No problem. 👍

Yeah, it seems harder than I thought. I know you take care of everything alone here. Thank you for your work!

@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

Hmmm... I don't think you need to close it, you can keep it open maybe one day this can be implemented.

@andreynering
Copy link
Contributor Author

@unknwon 👍

@andreynering andreynering reopened this Nov 11, 2015
@unknwon unknwon mentioned this issue Dec 17, 2015
Closed
@unknwon unknwon changed the title Feature request: side-by-side diff view Side-by-side diff view Dec 18, 2015
@bkcsoft
Copy link
Contributor

bkcsoft commented Dec 24, 2015

I'm currently working on this, will claim the issue as soon as I'm in front of a computer again

@unknwon unknwon added the status: assigned to community Take it on, you're the rockstar label Dec 25, 2015
@bkcsoft
Copy link
Contributor

bkcsoft commented Dec 26, 2015

Got it working! Now I just need some buttons for it ;)
2015-12-26-114558_1600x900_scrot

@bkcsoft bkcsoft mentioned this issue Dec 26, 2015
Closed
@unknwon unknwon added status: needs feedback Tell me more about it and removed status: assigned to community Take it on, you're the rockstar labels Jan 6, 2016
@unknwon unknwon added this to the 0.9.0 milestone Jan 6, 2016
@unknwon
Copy link
Member

unknwon commented Jan 6, 2016

This is claimed to be implemented by merging #2296

@bkcsoft
Copy link
Contributor

bkcsoft commented Jan 6, 2016

shouldn't this be closed? as the feature was merged with #2296 :)

@unknwon
Copy link
Member

unknwon commented Jan 7, 2016

@bkcsoft auto-close happens with commits are merged to master.

@bkcsoft
Copy link
Contributor

bkcsoft commented Jan 7, 2016 via email

@unknwon
Copy link
Member

unknwon commented Jan 11, 2016

Close as fixed.

@unknwon unknwon closed this as completed Jan 11, 2016
@illyasv
Copy link

illyasv commented Feb 2, 2017

just installed Gogs 0.9.115.0103 on the server, but can't find where to see the diff side by side, only Split View is available. Searched the discussions, but not found how to enable this function on our installation.

Can anyone help me to get that working?

@bkcsoft
Copy link
Contributor

bkcsoft commented Feb 2, 2017

@illyasv Split view is Side-by-Side view :)

@illyasv
Copy link

illyasv commented Feb 2, 2017

@bkcsoft but it doesn't work that way, please take a look at the attachment, when i click on Split View it just shows the same as on the screenshot, and there is no other option to change to other view.
split

@illyasv
Copy link

illyasv commented Feb 2, 2017

@bkcsoft one more adjustment to the issue: it appears when I want to compare branches, if I go to commit and open it's details, then the diff is shown side by side, but if I go to compare branches, the side-by-side option doesn't work.

@bkcsoft
Copy link
Contributor

bkcsoft commented Feb 2, 2017

@illyasv Seems to work just fine on try.gogs.io
2017-02-02-163136_1916x1036_scrot

@illyasv
Copy link

illyasv commented Feb 2, 2017

@bkcsoft I've just created a TestRepo1 there and added you as a collaborator. If you go to the Source tab, then click on the green "Compare" button, choose master and branch1 to compare you will see there is an option there to see a Split View, but it doesn't work, if you click on it you'll stay with the same inline view. Okay, i think it works this way not only for this TestRepo1, but for all currently hosted on try.gigs.io. Please try and you'll see what I mean.

@bkcsoft
Copy link
Contributor

bkcsoft commented Feb 3, 2017

Interesting, the compare-controller doesn't have any logic for split-view 😕 Should be relatively easy to add but I unfortunately don't have any time to work on it 🙁

@unknwon Maybe open this again? or a new issue for that bug.

@unknwon
Copy link
Member

unknwon commented Feb 3, 2017 •
edited

@bkcsoft I think file a new issue would be cleaner and more appropriate?

richmahn referenced this issue in unfoldingWord/dcs Jun 14, 2017
@sapk @lunny
Switch to keybase go-crypto (for some elliptic curve key) + test (#1925)
274149d 
* Switch to keybase go-crypto (for some elliptic curve key) + test

* Use assert.NoError 

and add a little more context to failing test description

* Use assert.(No)Error everywhere 🌈

and assert.Error in place of .Nil/.NotNil
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
4 participants
@illyasv @unknwon @bkcsoft @andreynering