Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate repository name if too long #2287

Closed
drsect0r opened this issue Dec 25, 2015 · 15 comments
Closed

Truncate repository name if too long #2287

drsect0r opened this issue Dec 25, 2015 · 15 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Milestone

Comments

@drsect0r
Copy link

If the name of the repository is too long It would be nice to truncate it with dots instead of messing up the dashboard.

@unknwon
Copy link
Member

unknwon commented Dec 25, 2015

Thanks your feedback!

Any exmaple screenshots?

@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 25, 2015
@unknwon unknwon added this to the 0.9.0 milestone Dec 25, 2015
@drsect0r
Copy link
Author

Right now I can't, however, a name longer than 40 characters should do it.

Happy Christmas!

@unknwon
Copy link
Member

unknwon commented Jan 1, 2016

ping @drsect0r

@drsect0r
Copy link
Author

drsect0r commented Jan 2, 2016

screenshot from 2016-01-02 02-09-31

@unknwon
Copy link
Member

unknwon commented Jan 2, 2016

Thank you!

@unknwon unknwon added 🔨 enhancement Make it better, faster 💻 ui You ruined my eyes! and removed status: needs feedback Tell me more about it labels Jan 2, 2016
@stonewareslord
Copy link

From my duplicate issue:

Here's a screenshot of the sidebar and news feed:

The names stretch past the "My Repositories" box and push the stars down. The second repo's star shifts repo-2's star to the left. In the news feed, the name overlaps with the repo icon. Github has some examples of of how this could be fixed

by using ellipses:

by breaking the line:

Both repositories have names with the maximum length (100)

@unknwon
Copy link
Member

unknwon commented Jan 7, 2016

Thanks your info @stonewareslord !

@unknwon unknwon added 💊 bug Something isn't working and removed 🔨 enhancement Make it better, faster labels Jan 7, 2016
@unknwon unknwon added the status: needs feedback Tell me more about it label Jan 11, 2016
@unknwon
Copy link
Member

unknwon commented Jan 11, 2016

Hi all, please test out develop branch or https://try.gogs.io/

@stonewareslord
Copy link

It almost works well. The repo names are truncated correctly on the dashboard:

selection_001

The repo URL on the right (in My Repositories) works, but the URL in the news feed doesn't. It is linking to try.gogs.io/username/repon... instead of try.gogs.io/username/reponame which gives a 404.

One more issue is that in the project page, the project name pushes down the Unwatch or Star buttons:

selection_002

selection_003

The profile page works well if the monitor is large enough:

selection_004

But when the window is smaller than the repo name, it just cuts off (instead of being broken into two lines as in the last Github screenshot in my previous comment):

selection_005

Here is what the dashboard and repo pages look like on a smaller monitor:

selection_006

selection_007

They look okay to me with the exception of the repo name pushing Unwatch and Star down.

unknwon added a commit that referenced this issue Jan 15, 2016
@unknwon
Copy link
Member

unknwon commented Jan 15, 2016

@stonewareslord URL fixes are pushed to develop.

And I found word-break: break-all does not work on Firefox, but perfectly under Chrome. I suggest you open another issue for this problem specifically since the main purpose of this issue is completed.

@bygreencn
Copy link

are you tried the full function test, this fix may cause the error message about "template: user/dashboard/feeds:10:52: executing "user/dashboard/feeds" at <.ShortActUserName>: ShortActUserName is not a field of struct type *models.Action". @unknwon

it looks like that you have not committed the file of "routers/user/home.go"

@unknwon
Copy link
Member

unknwon commented Jan 25, 2016

@bygreencn I think you update the source code but did not recompile the Gogs..?

@bygreencn
Copy link

i found the error.
i should call go get -u github.com\gogits\gogs first then call go build, even i had called git checkout the source code first.
but 应用配置管理 still has this bug.
by the way, should the version information be shown on control panel since easily checking program update correct for administrator.

@unknwon
Copy link
Member

unknwon commented Jan 26, 2016

@bygreencn I see, I think you're talking about this: #2416

@unknwon
Copy link
Member

unknwon commented Jan 29, 2016

Close as fixed.

@unknwon unknwon closed this as completed Jan 29, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Projects
None yet
Development

No branches or pull requests

4 participants