Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

rkt/image: clean asc object before every fetch #1991

Merged
merged 2 commits into from Jan 19, 2016

Conversation

iaguis
Copy link
Member

@iaguis iaguis commented Jan 18, 2016

If we don't do this, we could use the asc object from a previous image,
resulting on the incorrect signature being fetched.

Fixes #1982

cc @krnowak

If we don't do this, we could use the asc object from a previous image,
resulting on the incorrect signature being fetched.

Fixes rkt#1982
@alban
Copy link
Member

alban commented Jan 18, 2016

  • changelog
  • ideally, more tests in rkt_image_dependencies_test.go for this, but we don't have the test infrastructure to generate keys and signatures...

@iaguis
Copy link
Member Author

iaguis commented Jan 19, 2016

Added changelog.

Let's do signature tests later: #1994

@krnowak
Copy link
Collaborator

krnowak commented Jan 19, 2016

LFAD. Would be nice to hear from @dgonyeo if this fixes his issue.

@iaguis
Copy link
Member Author

iaguis commented Jan 19, 2016

I tested fetching his image and it Worked for Me (TM)

alban added a commit that referenced this pull request Jan 19, 2016
rkt/image: clean asc object before every fetch
@alban alban merged commit 25096d5 into rkt:master Jan 19, 2016
@cgonyeo
Copy link
Member

cgonyeo commented Jan 27, 2016

Sorry about the delay, but also works for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants