This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: add --full flag to fetch #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add a functional test. |
|
Added a test. |
iaguis
force-pushed
the
iaguis/fetch-full
branch
from
9c5e0c5
to
c2cb7c9
Compare
|
| @@ -200,7 +200,7 @@ func importImageAndFetchHashAsGid(t *testing.T, ctx *testutils.RktRunCtx, img st | |||
| } | |||
|
|
|||
| // Read out the image hash. | |||
| result, out, err := expectRegexWithOutput(child, "sha512-[0-9a-f]{32}") | |||
| result, out, err := expectRegexWithOutput(child, "sha512-[0-9a-f]{32,}") | |||
There was a problem hiding this comment.
What does {32,} mean? Either 32 characters or 1 character?
There was a problem hiding this comment.
x{n,} n or more x, prefer more
That sounds great but I think we should do that for in a consistent way for every command instead of trying to squeeze it in the current docs. We can do that in a follow-up. |
iaguis
force-pushed
the
iaguis/fetch-full
branch
from
c2cb7c9
to
ad20a3b
Compare
|
LGTM after a rebase, if Semaphore is still green. |
It prints the full image hash instead of a truncated one.
|
Rebased. |
iaguis
force-pushed
the
iaguis/fetch-full
branch
from
ad20a3b
to
4e81656
Compare
iaguis
force-pushed
the
iaguis/fetch-full
branch
from
4e81656
to
d62e8b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prints the full image hash instead of a truncated one.
Fixes #1967